No repeated primes in the limb moduli for CKKS #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dsuponitskiy
commented
Jun 5, 2024
•
dsuponitskiy
commented
- Make sure that the vector of moduliQ in ParamsGenCKKSRNS() has no duplicate values.
- Push error handling to the top of the function
- Reorganize code and replace usint with uint32_t
- Add unit tests
There was a problem hiding this comment.
Please add a unit test checking for small firstModSize = scalingModSize and for small firstModSize = scalingModSize + 1.
@dsuponitskiy You should be able to convert the examples from https://openfhe.discourse.group/t/crashes-with-specific-parameter-setting-in-ckks/1252/4 into unit tests
dsuponitskiy
force-pushed
the
766-repeated-primes-in-the-moduli-for-ckks
branch
2 times, most recently
from
14391f7
to
151ef85
Compare
andreea-alexandru
approved these changes
Jun 13, 2024
dsuponitskiy
force-pushed
the
766-repeated-primes-in-the-moduli-for-ckks
branch
from
9101e87
to
c5449ae
Compare
yspolyakov
reviewed
Jun 14, 2024
yspolyakov
reviewed
Jun 17, 2024
yspolyakov
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.