Enable omp in evalautomorphism #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascoec
reviewed
Jun 13, 2024
| (*evalKeys)[indicesToGenerate[i]] = algo->KeySwitchGen(privateKey, privateKeyPermuted); | ||
| privateKeyPermuted->SetPrivateElement(s.AutomorphismTransform(index, vec)); | ||
| #pragma omp critical | ||
| { (*evalKeys)[indicesToGenerate[i]] = algo->KeySwitchGen(privateKey, privateKeyPermuted); } | ||
| } |
There was a problem hiding this comment.
have you benchmarked this? probably faster to populate a vector inside the omp loop (no need for critical section) then populate the map from the vector afterwards.
if left as is, move computation outside of the critical section
auto ek = algo->KeySwitchGen(privateKey, privateKeyPermuted);
#pragma omp critical
{ (*evalKeys)[indicesToGenerate[i]] = ek; }
dsuponitskiy
force-pushed
the
797-enable-omp-in-evalautomorphism
branch
from
0005882
to
56e008f
Compare
pascoec
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some errors to enable OMP in EvalAutomorphismKeyGen()