Remove comments extraction not used and very slow on newer python versions #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
approved these changes
Jul 12, 2023
|
I would like to merge this PR with #1189 to avoid two major version bumps. I will wait a couple of days and if it looks like it's better to split them, I'll merge them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments extraction is not tested, doesn't seem to be used and is making the API very very very slow.
I am currently refactoring this section, it remains the source code extraction and generation but for comments it looks simpler as the logic can be removed.
Breaking changes
commentsremoved from the tuple returned232 seconds spent for an unused feature here:
A single long
findsourcetrace (and I'm working on it, I extracted that PR from my work)