Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dunder contains and dunder iter to TracingParameterNodeAtInstant #1200

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add dunder contains and dunder iter to TracingParameterNodeAtInstant #1200

merged 2 commits into from
Nov 13, 2023

Conversation

Allan-CodeWorks
Copy link
Contributor

@Allan-CodeWorks Allan-CodeWorks commented Nov 13, 2023 •
edited
Loading

41.3.0 #1200

As TracingParameterNodeAtInstant is a wrapper for ParameterNodeAtInstant
which allows iteration and the use of contains, it was not possible
to use those on a TracingParameterNodeAtInstant

New features

  • Allows iterations on TracingParameterNodeAtInstant
  • Allows keyword contains on TracingParameterNodeAtInstant

@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited
Loading

Coverage Status

coverage: 73.484% (-0.02%) from 73.501%
when pulling e26904a on TracingParameterNodeAtInstant_add_dunder_contains+iter
into 6a6e470 on master.

@Allan-CodeWorks Allan-CodeWorks merged commit 05980c4 into master Nov 13, 2023
22 checks passed
@Allan-CodeWorks Allan-CodeWorks deleted the TracingParameterNodeAtInstant_add_dunder_contains+iter branch November 13, 2023 17:04
@Allan-CodeWorks Allan-CodeWorks mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

@baptou12 baptou12 Awaiting requested review from baptou12

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Allan-CodeWorks @coveralls @benjello