Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spiral and cycle tests #1206

Merged
merged 9 commits into from
Mar 18, 2024
Merged

Improve spiral and cycle tests #1206

merged 9 commits into from
Mar 18, 2024

Conversation

guillett
Copy link
Member

@guillett guillett commented Feb 6, 2024 •
edited by bonjourmauko
Loading

Technical changes

  • Increase spiral and cycle tests robustness.
    • The current test is ambiguous, as it hides a failure at the first spiral occurrence (from 2017 to 2016).

@coveralls
Copy link

coveralls commented Feb 6, 2024 •
edited
Loading

Coverage Status

coverage: 74.492%. remained the same
when pulling 24ee6e9 on refacto-spiral-tests
into f6f6380 on master.

@guillett guillett mentioned this pull request Feb 7, 2024
Open
@bonjourmauko bonjourmauko self-requested a review March 18, 2024 12:48
@bonjourmauko bonjourmauko added the kind:refactor Refactoring and code cleanup label Mar 18, 2024
bonjourmauko
bonjourmauko approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@bonjourmauko bonjourmauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I allowed myself some subtle changes in the location of the test (as what you want to test was at the same time the tracer and the simulation, I've just split the test in two, to avoid testing the mock).

@bonjourmauko bonjourmauko merged commit 069c542 into master Mar 18, 2024
22 checks passed
@bonjourmauko bonjourmauko deleted the refacto-spiral-tests branch March 18, 2024 14:24
@bonjourmauko bonjourmauko added the level:starter Suited for beginners and new contributors label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonjourmauko bonjourmauko bonjourmauko approved these changes

Assignees
No one assigned
Labels
kind:refactor Refactoring and code cleanup level:starter Suited for beginners and new contributors
Projects
OpenFisca International
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillett @coveralls @bonjourmauko