Audio pitch change implementation

[ninjamuffin99]

Finally got hands dirty and figured out some of the backend stuff to get pitch changing stuff available.

I've tested Windows and HTML5, I'm just assuming most of the NativeBackend stuff works in a generally similar way.
NOT implemented Flash, I'm assuming it'd give you errors as getPitch() and setPitch() and the FlashAudioBackend aren't implemented.

I believe this closes #871

[Cheemsandfriends]

This seems to crash an hl build, or at least my results with hl were that.
Idk if it crashes more targets but yeah.

[Cheemsandfriends]

The two options go sweet in terms of pitch changing.
What it gives me a nerve is the other one, the native backend audio.
It seems that it works based and depending on a timer. Maybe there should be a new way to make the timer running better.

[player-03]

Hope you don't mind, but I copied @Cheemsandfriends's work over from #1512. (With a few changes.)

Looks like it fixed the CI error.

[Cheemsandfriends]

I'm kinda flattered that you used some of my work even tho it was some bad code lol

[ninjamuffin99]

nice work, CI seems to be fixed, was there anything else that may need to be implemented for this? Was HL crashing?
Would it be worth to do a little bit of documentation as well? Just some standard code block comments I guess. Feel like it might be worth to put SOMEWHERE that Flash pitch changing isn't really supported

[player-03]

Yeah, comments would be nice. You can refer to Application.hx for formatting examples. (Yeah the parameter descriptions don't all line up, but I guess that's just how we do things here.)

Other than that, I guess it's a matter of testing. Cheemsandfriends, does HL still crash for you?

[Cheemsandfriends]

nice work, CI seems to be fixed, was there anything else that may need to be implemented for this? Was HL crashing? Would it be worth to do a little bit of documentation as well? Just some standard code block comments I guess. Feel like it might be worth to put SOMEWHERE that Flash pitch changing isn't really supported

It isn't really supported but, you wouldn't trace UNSUPPORTED right?

And I don't know pretty much anything about Flash, tried to reproduce sounds but I couldn't hear them so I just gave up

[Cheemsandfriends]

Yeah, comments would be nice. You can refer to Application.hx for formatting examples. (Yeah the parameter descriptions don't all line up, but I guess that's just how we do things here.)

Other than that, I guess it's a matter of testing. Cheemsandfriends, does HL still crash for you?

I should check up the testing right now and tell if it correctly works or not wait a sec

[Cheemsandfriends]

Ok, I tested what @player-03 made and have some opinions about it.

1. It seems that in Flx, If you use it on Flixel, the timer will go nuts, so better use the pitch variable to only if the pitch is changed?
2. Seems a nice job, even though it was removed some functions that make the functions work good like setLength or setCurrentTime

[Cheemsandfriends]

I would want to make a commit here but idk if it's really possible lol

(Nvm, Just made a review comment on the pitch lol)

[player-03]

Oh, oops, I never got around to answering these questions. I think the correct way to add changes to this pull request is first to check out the branch. It'd look something like this:

> git remote add ninjamuffin99 https://github.com/ninjamuffin99/lime.git
> git fetch ninjamuffin99
> git switch -c pitch ninjamuffin99/pitch

That'll get you set up to make changes locally. You can push these changes to your own repo, at which point I think you can use this url to start a pull request.

It seems that in Flx, If you use it on Flixel, the timer will go nuts, so better use the pitch variable to only if the pitch is changed?

It should be possible to make this work, but it might be that the formula is off. I'm afraid I haven't yet tested it myself, as awful as that sounds. Just kind of reused your formula and hoped everything would work out.

Seems a nice job, even though it was removed some functions that make the functions work good like setLength or setCurrentTime

But... those are still there. Or are you saying they no longer work?

[Cheemsandfriends]

It should be possible to make this work, but it might be that the formula is off. I'm afraid I haven't yet tested it myself, as awful as that sounds. Just kind of reused your formula and hoped everything would work out.

It might be, I don't pretty know about coding since I just really started just a few months but the formula I made was like a play-and-test thing with my programming acknowledges. So if it is very off, i'm sorry lol

But... those are still there. Or are you saying they no longer work?

You removed the value option to getLength() That's why I said that it no longer works as intended lol
Either way I added the review comments on the things you made so you can check it out lol

[player-03]

Either way I added the review comments on the things you made so you can check it out lol

I still don't see those. Link?

[Cheemsandfriends]

I still don't see those. Link?

In the commits you made
If you can't see those, then I can post some photos to the reviews to check it out

[player-03]

Odd. I have "show comments" checked, and I still can't see them.

[Cheemsandfriends]

Odd. I have "show comments" checked, and I still can't see them.

Weird then I should post the images with the review then.
This is the review post where you changed the setCurrentTime Thing:

This is the review post where it was about the setLength thing

And this is the setPitch thing to make the setPitch something nice and not fucky when you set it when you're setting it on each frame

Idk why you can't see the review comments tho, It's a bug or something like that?

[player-03]

Ah, I see your points.

Interesting that your reviews are labeled "pending." That's probably why they aren't publicly visible. I didn't see a button to approve them, so perhaps only ninjamuffin99 can (being the owner of the fork).

[Cheemsandfriends]

I have a button to like approve the things, maybe I should approve it lol

[Cheemsandfriends]

Good but needs some more robust code to not lose the track of the thing

[Cheemsandfriends]

Oh heck, it was many review post XD

[Cheemsandfriends]

Seems good to me and to the CI

[Cheemsandfriends]

About the last commit, I have to check if it's correct or not cos maybe it was simply the bad positioning of the pitch thing
If I have results, I'll post it here.

[player-03]

CI seems to be failing on the download step. @joshtynjala, how did you fix this one?

[joshtynjala]

@player-03 I clicked the "Re-run all jobs" button in the summary page for the actions run.

It's probably just a temporary network issue today.

[Cheemsandfriends]

make a random commit, like add a space and remove it or some shit like that.
should restart the thing idk

[player-03]

No commit required; there's a re-run button. I was just giving it time in hopes the network would fix itself.

[Cheemsandfriends]

No commit required; there's a re-run button. I was just giving it time in hopes the network would fix itself.

Oh, nvm.
I just don't know how github works

[Geokureli]

What is the status of this?

[Cheemsandfriends]

What is the status of this?

tbh, Idk.
I'm kinda curious too tho

[player-03]

I don't like to be the one to merge my own changes - what if I missed something? So I leave it in hopes someone else will check it, though it seems this is what happens instead.

Well, since it's been approved for four months and no one spotted any issues, let's go for it.

[SomeGuyWhoLovesCoding]

Yooo ninjamuffin99 the creator of fnf 😱