Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation support. Fixes #41 #42

Merged
merged 1 commit into from
May 18, 2016
Merged

Rotation support. Fixes #41 #42

merged 1 commit into from
May 18, 2016

Conversation

ashes999
Copy link
Member

Please review the untranslate/retranslate code. I hope I got my algebra right (it's been a while ...)

@ashes999
Copy link
Member Author

Code review please? @jcward @Gama11

@jcward
Copy link
Contributor

jcward commented May 16, 2016

Looks good to me.

@ashes999
Copy link
Member Author

Please review @ibilon

@ashes999 ashes999 merged commit b1b6cf9 into openfl:master May 18, 2016
@ashes999
Copy link
Member Author

Looks like I merged this in by mistake. It still needs a review.

@ashes999 ashes999 mentioned this pull request May 29, 2016
@ibilon
Copy link
Member

ibilon commented Jun 29, 2016

According to https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/transform rotate(<a> [<x> <y>]) is equivalent to translate(<x>, <y>) rotate(<a>) translate(-<x>, -<y>) but here the translate are in the other order.

Also the x,y parameters should be optional, "If optional parameters x and y are not supplied, the rotate is about the origin of the current user coordinate system."

@ashes999
Copy link
Member Author

ashes999 commented Jul 5, 2016

I'll take a look at this next week.

Sorry to get the formula wrong. I reverse-engineered it (didn't think the SVG spec would mention it) from highschool algebra (move to origin, rotate, and move back).

ashes999 pushed a commit that referenced this pull request Aug 19, 2016
Code-review fixes for rotation (#41 and #42)
Reviewed by @ibilon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants