Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Nutri-Score game #93

Merged
merged 7 commits into from
Aug 10, 2022
Merged

feat: improve Nutri-Score game #93

merged 7 commits into from
Aug 10, 2022

Conversation

alexfauquette
Copy link
Member

Fix #63

  • The first commit is about
    • Making the game accessible in dev mode ("nutriscore" button in the menu)
    • stick the validate/reject buttons at the bottom of the page
    • allows modifying image size (out of the issue)
  • The second commit is just the result of yarn prettier

image

<Box sx={{ mx: 2, width: 500, maxWidth: 500, textAlign: "left" }}>
<Typography gutterBottom>Image sizes</Typography>
<Slider
aria-label="Temperature"
Copy link
Collaborator

@nobeeakon nobeeakon Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:v aria-label="Image size"?

@@ -44,9 +45,7 @@ const ResponsiveAppBar = () => {

const { devMode: isDevMode } = React.useContext(DevModeContext);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha made me think we could rename devMode

@teolemon teolemon changed the title improve nutriscore game feat: improve Nutri-Score game Aug 2, 2022
@VaiTon VaiTon requested a review from nobeeakon August 9, 2022 21:51
@teolemon
Copy link
Member

Explaining what you need to do ("Select all the products that have/don't have…") would be helpful. I didn't immediately understand how to play the game

@alexfauquette alexfauquette merged commit bcc612e into master Aug 10, 2022
@alexfauquette alexfauquette deleted the nutriscore-game branch August 10, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nutri-Score game
3 participants