Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(price add): move location to the proof section #648

Merged
merged 3 commits into from
Jun 23, 2024
Merged

feat(price add): move location to the proof section #648

merged 3 commits into from
Jun 23, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Jun 22, 2024 •
edited
Loading

What

Following #645

Screenshot

1. Proof selected 2. Proof uploaded
image Screenshot from 2024-06-23 11-12-15

@raphodn
Copy link
Member Author

raphodn commented Jun 23, 2024

@monsieurtanuki preview of how the new "add a price" UI will look like (the first step asking to select/upload a proof)

@monsieurtanuki
Copy link
Collaborator

@raphodn ¡Bueno! 😉
My initial point was at the database level - I come from the world of relational databases where redundant data are not welcome.
I have no specific ideas regarding UI/UX though. For the record in Smoothie we have everything on the same page with vertical scrolling, something like proof, location, currency, and then product prices.

@raphodn raphodn marked this pull request as ready for review June 23, 2024 10:07
@raphodn
Copy link
Member Author

raphodn commented Jun 23, 2024

Created a discussion here : openfoodfacts/open-prices#339

@raphodn raphodn merged commit 67a3d62 into master Jun 23, 2024
4 checks passed
@raphodn raphodn deleted the raphodn/price-add-proof-location branch June 23, 2024 10:19
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jun 23, 2024
Merged
@raphodn raphodn mentioned this pull request Jun 24, 2024
Merged
@raphodn raphodn linked an issue Jun 24, 2024 that may be closed by this pull request
Proof: link a date, location & currency #634
Closed
raphodn added a commit that referenced this pull request Jul 3, 2024
@raphodn
fix(price add): set price location when selecting existing proof with…
ea96ad3 
… location. ref #648
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphodn raphodn

Labels
Price addition
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proof: link a date, location & currency
2 participants
@raphodn @monsieurtanuki