Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update suggestions in more situations #10149

Merged

Conversation

Naruyoko
Copy link
Contributor

@Naruyoko Naruyoko commented Apr 18, 2024

What

Suggestions do not update on emptying input, adding a tag, and editing existing tags. This change updates them more aggressively.

Related issue(s) and discussion

@Naruyoko Naruyoko changed the title Update suggestions in more situations fix: Update suggestions in more situations Apr 18, 2024
@Naruyoko Naruyoko added the ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii label Apr 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.68%. Comparing base (dc04d18) to head (40ff78d).
Report is 263 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10149      +/-   ##
==========================================
+ Coverage   49.54%   49.68%   +0.14%     
==========================================
  Files          67       71       +4     
  Lines       20650    20980     +330     
  Branches     4980     5025      +45     
==========================================
+ Hits        10231    10424     +193     
- Misses       9131     9264     +133     
- Partials     1288     1292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @Naruyoko

@Naruyoko Naruyoko marked this pull request as ready for review April 23, 2024 21:44
@Naruyoko Naruyoko requested a review from a team as a code owner April 23, 2024 21:44
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit aae2230 into openfoodfacts:main Apr 24, 2024
13 checks passed
john-gom pushed a commit that referenced this pull request May 24, 2024
Update suggestions in more situations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii multilingual products
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants