Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use prepared nutrition values to compute nutriscore of cocoa and chocolate powders #6552

Merged
merged 3 commits into from
Apr 5, 2022
Merged

fix: use prepared nutrition values to compute nutriscore of cocoa and chocolate powders #6552

merged 3 commits into from
Apr 5, 2022

Conversation

stephanegigandet
Copy link
Contributor

fixes #6551

also added some comments in the taxonomy

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 4, 2022 09:34
@stephanegigandet stephanegigandet self-assigned this Apr 4, 2022
@github-actions github-actions bot added categories Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests labels Apr 4, 2022
@stephanegigandet stephanegigandet added 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore and removed 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories 🧪 tests Food.pm labels Apr 4, 2022
@alexgarel
Copy link
Member

alexgarel commented Apr 4, 2022 •
edited

@stephanegigandet you have to update t/nutriscore.t

Failed test 'could not load expected_test_results/nutriscore/cocoa-and-chocolate-powders.json'

@github-actions github-actions bot added categories Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels Apr 5, 2022
@stephanegigandet
Copy link
Contributor Author

@stephanegigandet you have to update t/nutriscore.t

I added a test and forgot to add the file with the expected result, fixed.

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@alexgarel alexgarel merged commit fceefac into main Apr 5, 2022
@alexgarel alexgarel deleted the cocoa-powders-nutriscore branch April 5, 2022 08:20
@alexgarel alexgarel mentioned this pull request Apr 5, 2022
Merged
@teolemon teolemon added this to the 1.1.1 milestone Apr 5, 2022
@teolemon teolemon added the Cocoa label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
categories Cocoa Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

Wrong Nutri-Score for some cocoa / chocolate powders
3 participants
@stephanegigandet @alexgarel @teolemon