-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Estimate Ingredient percentages from nutritional data #8025
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #8025 +/- ##
=========================================
+ Coverage 0 48.53% +48.53%
=========================================
Files 0 114 +114
Lines 0 21294 +21294
Branches 0 4773 +4773
=========================================
+ Hits 0 10335 +10335
- Misses 0 9679 +9679
- Partials 0 1280 +1280
... and 113 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Just one minor request to remove the ciqual_food_code field when its value is "null"
I was anticipating a scenario where an ingredient was incorreclty assigned to a CIQAL code in the past, so we would need to remove any existing link. Should I delete instead in this case? |
Kudos, SonarCloud Quality Gate passed! |
What
Store the ciqual_food_code on each ingredient and calculate the number of ingredients that don't have Ciqual codes (ingredients_without_ciqual_codes_n) and list these (ingredients_without_ciqual_codes) to help prioritise updating taxonomies to have the biggest impact
New option --assign-ciqual-codes added to update_all_products.pl
Related issue(s) and discussion