Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Croatian language taxonomy for processing #8127

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

benbenben2
Copy link
Collaborator

WHAT?
Added Croatian language for food processing
Added 2 unit tests *
(added 1 more entry in Croatian taxonomy for processing)
(there were a couple of tests at the end in different language, there are now at the end of their respective languages => and after "make lint" it looks like a lot of things have changed in the file, sorry for that)

* Remark: the case where [ingredient + processing] is a sub-ingredient in parenthesis was not yet included in the tests (like "antioksidans (ekstrakt ružmarina)"). That was a bit tricky to handle, but now it is included in the tests as well.

@benbenben2 benbenben2 requested a review from a team as a code owner February 21, 2023 22:26
@benbenben2 benbenben2 self-assigned this Feb 21, 2023
@github-actions github-actions bot added 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients - processing 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests labels Feb 21, 2023
@teolemon teolemon added the 🇭🇷 Croatia https://hr.openfoodfacts.org/ label Feb 23, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2 benbenben2 merged commit 94faf7c into main Feb 24, 2023
@benbenben2 benbenben2 deleted the feat_include_hr_lang_taxonomy_for_processing branch February 24, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇭🇷 Croatia https://hr.openfoodfacts.org/ 🥗 Ingredients - processing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants