Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete old logo of a-market #8222

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Conversation

manon-corneille
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #8222 (76d67b3) into main (34ac1f1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8222   +/-   ##
=======================================
  Coverage   47.06%   47.06%           
=======================================
  Files         104      104           
  Lines       20449    20449           
  Branches     4650     4650           
=======================================
  Hits         9624     9624           
  Misses       9678     9678           
  Partials     1147     1147           
Impacted Files Coverage Δ
tests/unit/tags.t 88.75% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet
Copy link
Contributor

It turns out there are different characters: ä-märket <=> ä-märket (which may or may not look the same on your system!)

image

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a better solution when we tackle #8225

@stephanegigandet stephanegigandet merged commit fcde6da into main Mar 17, 2023
@stephanegigandet stephanegigandet deleted the manon-corneille-patch-2 branch March 17, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants