Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Taxonomy hr 20230401 #8284

Merged
merged 4 commits into from
Apr 7, 2023
Merged

taxonomy: Taxonomy hr 20230401 #8284

merged 4 commits into from
Apr 7, 2023

Conversation

benbenben2
Copy link
Collaborator

@benbenben2 benbenben2 commented Apr 4, 2023

used chatgpt to pluralize categories in HR

  • added few ingredients/labels

@benbenben2 benbenben2 self-assigned this Apr 4, 2023
@github-actions github-actions bot added categories 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Apr 4, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #8284 (73dbbcc) into main (ff60457) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8284   +/-   ##
=======================================
  Coverage   47.05%   47.05%           
=======================================
  Files         109      109           
  Lines       20992    20992           
  Branches     4737     4737           
=======================================
  Hits         9878     9878           
  Misses       9947     9947           
  Partials     1167     1167           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge as-is, but it would be a good idea to also keep the singular as a synonym, so that we can match the category if someone uses the singular (or if we get it from a producer import)

@benbenben2
Copy link
Collaborator Author

Yes, yes, yes. I will apply those changes

@benbenben2
Copy link
Collaborator Author

@stephanegigandet, singular are kept in the last commit

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@stephanegigandet stephanegigandet merged commit 5975aa5 into main Apr 7, 2023
@stephanegigandet stephanegigandet deleted the taxonomy_HR_20230401 branch April 7, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants