Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix OpenAPI Product schema file, extract agribalyze.yaml #8450

Merged
merged 2 commits into from
May 25, 2023
Merged

docs: fix OpenAPI Product schema file, extract agribalyze.yaml #8450

merged 2 commits into from
May 25, 2023

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented May 23, 2023

Closes #8449

@VaiTon VaiTon requested a review from a team as a code owner May 23, 2023 19:02
@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label May 23, 2023
@VaiTon VaiTon mentioned this pull request May 23, 2023
Merged
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #8450 (6528129) into main (7953dbc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8450   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files         114      114           
  Lines       21343    21343           
  Branches     4779     4779           
=======================================
  Hits        10376    10376           
  Misses       9680     9680           
  Partials     1287     1287

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VaiTon VaiTon changed the title docs: fix OpenAPI Product schema file docs: fix OpenAPI Product schema file, extract agribalyze.yaml May 24, 2023
@github-actions github-actions bot added the API WRITE WRITE API to allow sending product info and image label May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @VaiTon ! It's really appreciated.

@alexgarel alexgarel merged commit f970234 into main May 25, 2023
@alexgarel alexgarel deleted the fix/product-openapi branch May 25, 2023 07:48
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 25, 2023
Merged
MonalikaPatnaik pushed a commit to MonalikaPatnaik/openfoodfacts-server that referenced this pull request May 31, 2023
@VaiTon @MonalikaPatnaik
docs: fix OpenAPI Product schema file, extract agribalyze.yaml (ope…
47160ba 
…nfoodfacts#8450)

* docs: fix OpenAPI `Product` schema file

* fix: typo in agribalise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

Assignees

@VaiTon VaiTon

Labels
API WRITE WRITE API to allow sending product info and image 📚 Documentation Documentation issues improve the project for everyone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Product schema in OpenAPI does not work with code gen tools
3 participants
@VaiTon @codecov-commenter @alexgarel