feat: Timeout before calling autocomplete #8790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teolemon
added
✏️ Editing - Auto Suggest
github-actions
bot
added
GitHub Actions
duhow
force-pushed
the
taxonomy-suggestion-optimized
branch
from
9540b4b
to
969f539
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| debounceTimer = setTimeout(function(){ | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/AbortController/abort | ||
| if (abortController) { |
There was a problem hiding this comment.
Shouldn't we do the abort before the setTimeout? i.e. when the user types something, we cancel the previous request immediately, and then we issue the request after 300ms? Otherwise we could get back suggestions that don't match all the letters we typed.
|
Good idea I think, I will test it. |
teolemon
added
✏️ Editing - Auto Suggest
|
Seems to work quite well. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As users are writing into Tagified content that performs autocompletion, each letter typed will result in an immediate call to API.
This amounts of requests and cancellations may overload the API service, which in turn cause that lookup takes long (+5 seconds to get response).
In order to improve this situation:
timeoutstarts.timeoutwill restart from beginning.timeoutcompletes, the REST API call will be executed.NOTE: This code is not tested. Feel free to make any additional changes required.
Part of