fix: Nova 4 marker for mechanicaly separated meat and fruit juice concentrates + better Halal / Kosher parsing #9074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧬 Taxonomies
Codecov Report
@@ Coverage Diff @@
## main #9074 +/- ##
=======================================
Coverage 47.81% 47.81%
=======================================
Files 64 64
Lines 19942 19942
Branches 4823 4823
=======================================
Hits 9536 9536
Misses 9162 9162
Partials 1244 1244
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raphael0202
approved these changes
Sep 28, 2023
|
There is a merge conflict with |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds entries for mechanically separated meat, and makes it a NOVA 4 marker, along with fruit juice concentrates, as they are listed on https://www.fao.org/3/ca5644en/ca5644en.pdf (NOVA paper from Carlos Monteiro 2019).
We have ingredients processing for "mechanically separated" and "concentrated", and we currently do not support NOVA 4 markers for processings, so this is currently not perfect. We can continue to improve it and add support for ingredients processing markers (and keeping an eye on potential false positives that could come from "concentrated" ingredients that are not fruit juices).
This PR also adds support for Halal and Kosher labels, so that we can parse things like "viande séparée mécaniquement de poulet halal"