-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add is_in_taxonomy boolean flag in ingredient parsing result #9968
feat: Add is_in_taxonomy boolean flag in ingredient parsing result #9968
Conversation
@himanshisrestha Could you update your branch with the main branch and update the tests results? It should solve the food_group issue. |
I should run the command |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9968 +/- ##
==========================================
+ Coverage 49.54% 49.65% +0.11%
==========================================
Files 67 71 +4
Lines 20650 20980 +330
Branches 4980 5028 +48
==========================================
+ Hits 10231 10418 +187
- Misses 9131 9270 +139
- Partials 1288 1292 +4 ☔ View full report in Codecov by Sentry. |
@stephanegigandet This is ready for review, please share your insights |
@himanshisrestha what you did looks good but you still have tests failing. Can you fix them ? |
Sure .. Working on it |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…9968) * Add is_in_taxonomy boolean flag in ingredient parsing result * fix isInTaxonomy update test results * lint added * expected results updated for ingredients processing unit test * modified expected results in ingredient nesting unit test * added is_in_taxonomy to fix api_v2_product_read tests * updated test results to multiple files * update test results in search
What
Added is_in_taxonomy boolean flag when the server is searching for the ingredient in the taxonomy. A screenshot to the current change is attached below.
Screenshot
Updated result after fix for food_groups
Related issue(s) and discussion
isInTaxonomy
boolean flag in ingredient parsing result #9930