Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add is_in_taxonomy boolean flag in ingredient parsing result #9968

Merged
merged 10 commits into from
Apr 19, 2024

Conversation

himanshisrestha
Copy link
Contributor

@himanshisrestha himanshisrestha commented Mar 21, 2024

What

Added is_in_taxonomy boolean flag when the server is searching for the ingredient in the taxonomy. A screenshot to the current change is attached below.

Screenshot

Screenshot 2024-03-20 at 11 12 46 PM

Updated result after fix for food_groups

Screenshot 2024-03-31 at 11 47 53 AM

Related issue(s) and discussion

@stephanegigandet
Copy link
Contributor

@himanshisrestha Could you update your branch with the main branch and update the tests results? It should solve the food_group issue.

@himanshisrestha
Copy link
Contributor Author

@himanshisrestha Could you update your branch with the main branch and update the tests results? It should solve the food_group issue.

I should run the command make update_tests_results again right before opening the PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.65%. Comparing base (dc04d18) to head (2062438).
Report is 249 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9968      +/-   ##
==========================================
+ Coverage   49.54%   49.65%   +0.11%     
==========================================
  Files          67       71       +4     
  Lines       20650    20980     +330     
  Branches     4980     5028      +48     
==========================================
+ Hits        10231    10418     +187     
- Misses       9131     9270     +139     
- Partials     1288     1292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshisrestha himanshisrestha marked this pull request as ready for review March 31, 2024 06:12
@himanshisrestha himanshisrestha requested a review from a team as a code owner March 31, 2024 06:12
@himanshisrestha
Copy link
Contributor Author

@stephanegigandet This is ready for review, please share your insights

@alexgarel
Copy link
Member

@himanshisrestha what you did looks good but you still have tests failing. Can you fix them ?

@himanshisrestha
Copy link
Contributor Author

Sure .. Working on it ☺️

@github-actions github-actions bot added the 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis label Apr 4, 2024
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit bb240bc into openfoodfacts:main Apr 19, 2024
12 checks passed
john-gom pushed a commit that referenced this pull request May 24, 2024
…9968)

* Add is_in_taxonomy boolean flag in ingredient parsing result

* fix isInTaxonomy update test results

* lint added

* expected results updated for ingredients processing unit test

* modified expected results in ingredient nesting unit test

* added is_in_taxonomy to fix api_v2_product_read tests

* updated test results to multiple files

* update test results in search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Add isInTaxonomy boolean flag in ingredient parsing result
4 participants