Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a double-response mechanism in the scan screen (first offline, then online refresh if network is available) #2451

Closed
1 task
Tracked by #18
, #2446 ,  #2444
...
teolemon opened this issue Jun 30, 2022 · 4 comments · Fixed by #2632
Closed
1 task
Tracked by #18
, #2446 ,  #2444
...

Implement a double-response mechanism in the scan screen (first offline, then online refresh if network is available) #2451

teolemon opened this issue Jun 30, 2022 · 4 comments · Fixed by #2632
Assignees
@AshAman999
Labels
Offline - Browsing Offline
Milestone
Offline Scan

Comments

@teolemon
Copy link
Member

teolemon commented Jun 30, 2022 •
edited
Loading

What

  • Implement a double-response mechanism in the scan screen (first offline, then online refresh if network is available)

Part of
This was referenced Jun 30, 2022
Closed
Closed
@teolemon teolemon added this to the Offline Scan milestone Jun 30, 2022
@M123-dev
Copy link
Member

M123-dev commented Jul 2, 2022

Should already be in place, just named cache

@AshAman999
Copy link
Member

I guess what it meant is show the cached product, but if network is there automatically update it, without even the user knowing it ?
Is it what's intented here ???

@M123-dev
Copy link
Member

I guess so @AshAman999

@teolemon

@AshAman999
Copy link
Member

Could be done with a few lines of code, would do a PR by EOD

@AshAman999 AshAman999 self-assigned this Jul 19, 2022
@AshAman999 AshAman999 mentioned this issue Jul 19, 2022
Merged
@teolemon teolemon mentioned this issue Jul 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshAman999 AshAman999

Labels
Offline - Browsing Offline
Projects
📶 🤳 Offline scan/experience
Archived in project
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Offline Scan
Development

Successfully merging a pull request may close this issue.

fix: double-response mechanism in the scan screen AshAman999/smooth-app
3 participants
@teolemon @M123-dev @AshAman999