Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Track edit events #3755

Merged
merged 15 commits into from
Mar 16, 2023
Merged

Conversation

AshAman999
Copy link
Member

@AshAman999 AshAman999 commented Mar 2, 2023

What

  • Add Matomo events for tracking edits
  • Complete

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner March 2, 2023 16:11
@github-actions github-actions bot added 📈 Analytics We use Sentry and Matomo, with an opt-in system Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page labels Mar 2, 2023
@AshAman999 AshAman999 marked this pull request as draft March 2, 2023 16:12
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy @AshAman999 sorry for my somewhat delayed review, the core looks great you've managed to make it very compact, thats great

@teolemon
Copy link
Member

teolemon commented Mar 9, 2023

Great, It would really be nice to get this in the next version 👍

@github-actions github-actions bot added ✏️ Editing - Nutrition input ✏️ Editing - Packaging input Related to the structured input of food packaging. and removed PR: needs rebase labels Mar 12, 2023
@AshAman999
Copy link
Member Author

AshAman999 commented Mar 12, 2023

Edit:
Complete and ready to review

@AshAman999 AshAman999 marked this pull request as ready for review March 12, 2023 12:45
@monsieurtanuki
Copy link
Contributor

Though I think i was able to handle most of the event trackings , i think i am getting confused in the simple_input_page.dart.

I am not able to find a correct way as of today for getting the type of edit from within the page itself , added a TODO for the same in packages\smooth_app\lib\pages\product\simple_input_page.dart Line 185 , would seek some help here 😅

Hi @AshAman999! There's no "better way" to get the edit type from the page. It's either "there's just one type involved" or "there are several types involved". In both cases it's final List<AbstractSimpleInputPageHelper> helpers.
So helpers is the solution you're looking for. Does that fit the types you expect for the track edit, that's another story.

@AshAman999
Copy link
Member Author

Though I think i was able to handle most of the event trackings , i think i am getting confused in the simple_input_page.dart.
I am not able to find a correct way as of today for getting the type of edit from within the page itself , added a TODO for the same in packages\smooth_app\lib\pages\product\simple_input_page.dart Line 185 , would seek some help here 😅

Hi @AshAman999! There's no "better way" to get the edit type from the page. It's either "there's just one type involved" or "there are several types involved". In both cases it's final List<AbstractSimpleInputPageHelper> helpers. So helpers is the solution you're looking for. Does that fit the types you expect for the track edit, that's another story.

Figured out the solution, thanks for the resuce @monsieurtanuki 😄

Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
@monsieurtanuki
Copy link
Contributor

@AshAman999 @M123-dev How come?
Capture d’écran 2023-03-13 à 14 52 17

@M123-dev
Copy link
Member

That is long 🫣
Just force-canceled it, but I guess this is some kind of bug, I'm sure they have timeouts in place

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshAman999!
I haven't followed the issue from the beginning, but except my 2 suggestions and the fact that you don't like trailing commas, that's good for me!

@AshAman999
Copy link
Member Author

Seems like the tests gonna run foreover again, @M123-dev ,
Manually cancelling the workflow for now

image

@teolemon teolemon merged commit cd04400 into openfoodfacts:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system dependencies ✏️ Editing - Nutrition input ✏️ Editing - Packaging input Related to the structured input of food packaging. GitHub Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants