-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Track edit events #3755
chore: Track edit events #3755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyy @AshAman999 sorry for my somewhat delayed review, the core looks great you've managed to make it very compact, thats great
packages/smooth_app/lib/pages/product/add_basic_details_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/edit_ingredients_page.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/product_image_gallery_view.dart
Outdated
Show resolved
Hide resolved
Great, It would really be nice to get this in the next version 👍 |
Edit: |
Hi @AshAman999! There's no "better way" to get the edit type from the page. It's either "there's just one type involved" or "there are several types involved". In both cases it's |
Figured out the solution, thanks for the resuce @monsieurtanuki 😄 |
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
@AshAman999 @M123-dev How come? |
That is long 🫣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AshAman999!
I haven't followed the issue from the beginning, but except my 2 suggestions and the fact that you don't like trailing commas, that's good for me!
Seems like the tests gonna run foreover again, @M123-dev , |
What
Part of