Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defragment the history/list experience #4041

Open
4 of 10 tasks
Tracked by #525
teolemon opened this issue May 28, 2023 · 14 comments
Open
4 of 10 tasks
Tracked by #525

Defragment the history/list experience #4041

teolemon opened this issue May 28, 2023 · 14 comments

Comments

@teolemon
Copy link
Member

teolemon commented May 28, 2023

What

  • We currently have
    • History of products loaded by the app (in the History tab)
    • History of scans (in the user profile, not accessible unless you are logged in)
    • Lists (no default lists are created on app install, migrated users will have the default lists from the old app)
  • We should rename the "History" tab into "History & Lists" or just "Lists" (with a history icon ?)
  • We should see "Scan history" and "Products opened in the app" as just 2 specific lists.
  • I would like to see a "Shopping list", "Product I bought" default lists

Tasks

  1. User lists 🌐 l10n 🥫 Product page
    monsieurtanuki
  2. User lists 🐛 bug
    monsieurtanuki
  3. PR: needs rebase 🌐 l10n 🥫 Product page
    g123k
  4. User lists 🤗 Onboarding
  5. ⭐ top issue User lists good first issue lists 🎯 P1
  6. cross-platform experience lists
  7. P2 lists sharing ✨ enhancement
  8. 0 of 4
    Data export privacy 🎯 P0

References

What do you think ?

@monsieurtanuki
Copy link
Contributor

@teolemon If we change "History" into "Lists", we could have a "more ..." button on the app bar where you would list the lists (haha), and eventually provide admin actions (e.g. create list).

Something like:

(app bar) Product history (...)

  • Scan history
  • Shopping list
  • Products I bought
  • My breakfast

  • Create list

@monsieurtanuki
Copy link
Contributor

@teolemon It would look like this:

"more" button expanded menu
Screenshot_2023-07-06-08-23-06 Screenshot_2023-07-06-08-23-15

@monsieurtanuki
Copy link
Contributor

@g123k I have a good news and a bad news.

The good news is that we can retrieve the list of user lists without async, so adding the user lists to the current page is not a problem.

The bad news is that the solution you recommended (SmoothModalSheet) is not adapted for long lists (by "long" I mean more than 3, at least on my smartphone), as you can see:
Screenshot_2023-07-12-19-37-24
I use Column. Perhaps a ListView would do the trick, but there's always that tap dancing about computing the size.
Anyway, we would have half a screen (as in a modal bottom sheet) and would have to scroll in that half screen. Not very nice, UX-wise.
A solution could be to swap the app bar buttons:

  • a "... more" button that displays all the other lists, and we let flutter deal with long lists
  • an "action" button that has a limited set of actions (rename, clear, open in web, share), which would be easier to display in a limited space

@g123k
Copy link
Collaborator

g123k commented Jul 12, 2023

For your UI question, I have checked what Google Maps/Apple Plan do and they have a bottom sheet, with an inner scroll.
If necessary I can implement it, but basically, you take half of the screen, when you scroll up, the modal take the full width and then you scroll within the content.

Here is what it could look like:

Collapsed:
iPhone 13 Pro Max 2 2

Expanded:
iPhone 13 Pro Max 2

This is what I would like to implement for KP

(An improvement could be to "star" a list, and then it will be on top of it)

@monsieurtanuki
Copy link
Contributor

I would like to see a "Shopping list", "Product I bought" default lists

@teolemon Are you talking about "system" lists (unremovable and unrenamable like "history") or just 2 user lists that we build by default?
The "system" lists would be much easier to implement, especially for localization reasons.

@teolemon
Copy link
Member Author

teolemon commented Aug 5, 2023

  • For those two, I would go with system lists, and trying to convert existing custom lists in the wild into system lists (matching any list in English or any of the translations we have)

@monsieurtanuki
Copy link
Contributor

@teolemon Ok to create two "system" lists (unremovable and unrenamable like "history") for "Shopping list" and "Products I bought".

For "Shopping list" in the real world there are numbers of items too, like what we coded about 2 years ago (including "pantry" lists). I'm afraid that could cause confusion to display a shopping list without the number of items.

@teolemon
Copy link
Member Author

  • Auto-add icons to special lists

image

@monsieurtanuki
Copy link
Contributor

@teolemon What about the number of products? That would be expected of a shopping list or a picnic.
We could start with "my favorite foods" (with a fast-track "heart" icon to add any product), and with "products I bought". In both cases no number of products is required/expected.

@teolemon
Copy link
Member Author

  • I have no good (input/display) UI yet for it. I still need to research it.
  • I have been looking in the direction of Stock apps and Nutrition apps, which approach it in very different ways.
  • I want our solution to be easy and not intimidating.

@g123k
Copy link
Collaborator

g123k commented Aug 15, 2023

If we want a simple solution, we should embed a gallery of icons and let users choose one per list.
Way easier than trying to guess what's behind a name

EDIT: I'm sorry, I'm off topic

@teolemon
Copy link
Member Author

@monsieurtanuki is talking quantities

@teolemon
Copy link
Member Author

teolemon commented Aug 27, 2023

For the scanning part, I used Simply Stock today, and I found their system with + - and a dropdown quite convenient. It could be a dedicated "Stock mode" for the scanner. Eg. NOT activated by default @monsieurtanuki @g123k

@monsieurtanuki
Copy link
Contributor

For the scanning part, I used Simply Stock today, and I found their system with + - and a dropdown quite convenient. It could be a dedicated "Stock mode" for the scanner.

@teolemon Regardless of the "stock +1/-1" feature, it could be very cool to be able to

  • add the product to a list directly from the scan page
  • when on product list page, multi-select products to add them to a list

@monsieurtanuki monsieurtanuki removed their assignment Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

3 participants