-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stimulus_reflex and cable_ready from 3.5.0-preX to 3.5.0-rc2 #10619
Bump stimulus_reflex and cable_ready from 3.5.0-preX to 3.5.0-rc2 #10619
Conversation
d525b94
to
e2db3c7
Compare
Currently blocked by stimulusreflex/stimulus_reflex#649 |
stimulusreflex/stimulus_reflex#650 (comment)
|
A newer version of stimulus_reflex exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
c652f73
to
1e2fe00
Compare
Blocked by stimulusreflex/cable_ready#272 |
1e2fe00
to
74635b0
Compare
After a great debugging session with @marcoroth, we've found a fix to solve the issue (explained here) we had: 8a559ca Then, this one is ready to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Hopefully this gets simpler as it matures further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I'll just try a "quick" fixup.
Gemfile.lock
Outdated
2.4.3 | ||
2.4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got the wrong bundler installed! 😉
We better update this in a separate PR.
Updating JS and Ruby libraries. This commit was started by Dependabot for 3.5.0-rc1. Then we updated to rc2. Old Dependabot message about rc1: Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex) from 3.5.0-pre9 to 3.5.0-rc1. - [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases) - [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md) - [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits) --- updated-dependencies: - dependency-name: stimulus_reflex dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump cable_ready from 5.0.0-pre10 to 5.0.0-rc1 Bumps [cable_ready](https://github.com/stimulusreflex/cable_ready) from 5.0.0-pre10 to 5.0.0-rc1. - [Release notes](https://github.com/stimulusreflex/cable_ready/releases) - [Changelog](https://github.com/stimulusreflex/cable_ready/blob/main/CHANGELOG.md) - [Commits](https://github.com/stimulusreflex/cable_ready/commits) --- updated-dependencies: - dependency-name: cable_ready dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
``` DEPRECATED: CableReady's `render operations:` call has been renamed to `render cable_ready:`. Please update your render call. ```
Thanks @marcoroth for the great debugging session! 🙏
8a559ca
to
66307c9
Compare
I added testing notes. I think it would be good for this release candidate to be tested on staging. |
Bumps stimulus_reflex from 3.5.0-pre9 to 3.5.0-rc2.
+ Bumps cable_ready from 5.0.0-pre10 to 5.0.0-rc2.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Testing