Unexpected ActiveRecord::StatementInvalid #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
reviewed
Aug 15, 2018
There was a problem hiding this comment.
Pau and I discussed at some point that we would like to test with Postgres instead of Sqlite, because that's the database we use in OFN. Can you try to run it with Postgres and see if that solves this spec issue? Do you have access to the Semaphore project to change the configuration?
| @product2 = create(:product, :name => 'foo') | ||
| lambda do | ||
| @product2.update_attributes(:permalink => @product1.permalink) | ||
| end.should raise_error(ActiveRecord::RecordNotUnique) | ||
| end.should raise_error(ActiveRecord::StatementInvalid, /SQLite3::ConstraintException/) |
There was a problem hiding this comment.
Is there a more general error we can test here? We actually don't want to use sqlite.
There was a problem hiding this comment.
I was able to test with Postgres and it doesn't fail ! Should we keep AR::RecordNotUnique then ?
There was a problem hiding this comment.
Yes, the fewer patches we need, the better. :-) Thank you for testing.
|
This can be closed since #17 solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ? Why ?
Closes openfoodfoundation/openfoodnetwork#2537
I replaced the
RecordNotUniquebyStatementInvalidwithSQLite3::ConstraintExceptionto fit the expectedrecord not uniqueerror.