Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Pint 0.20.0 #51

Merged
merged 8 commits into from
Nov 2, 2022
Merged

Update for Pint 0.20.0 #51

merged 8 commits into from
Nov 2, 2022

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Oct 27, 2022 •
edited
Loading

Description

This PR includes updates for compatibility with Pint 0.20.0

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Re-exports Quantity, Measurement, and Unit mirrored from new locations in the Pint API
  • Removes the speed alias, which is now forbidden for reasons I don't follow

Questions

Status

  • Ready to go

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #51 (7b0d187) into main (0b50def) will decrease coverage by 0.58%.
The diff coverage is 100.00%.

Additional details and impacted files

mattwthompson added a commit to openforcefield/openff-toolkit that referenced this pull request Oct 27, 2022
@mattwthompson
Test openforcefield/openff-units#51
ce4a8c3
@mattwthompson mattwthompson mentioned this pull request Oct 27, 2022
Merged
@mattwthompson
Copy link
Member Author

Mypy is unhappy but this is, so far, doing everything I want it to.

@mattwthompson mattwthompson mentioned this pull request Nov 1, 2022
Merged
9 tasks
j-wags
j-wags approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks @mattwthompson!

@mattwthompson
Copy link
Member Author

Thanks!

@mattwthompson mattwthompson merged commit 878083a into main Nov 2, 2022
@mattwthompson mattwthompson deleted the pint-0.20 branch November 2, 2022 21:06
mattwthompson added a commit to openforcefield/openff-toolkit that referenced this pull request Nov 3, 2022
@mattwthompson
Update for Pint 0.20 (#1444)
3111949 
* Test openforcefield/openff-units#51

* Fix syntax for `pip`

* Include all test environments

* Try directly installing new versions

* Update Pint pin

* Fix

* Short-circuit tests

* Fix

* `SyntaxError` -> `pint.DefinitionSyntaxError`

* Remove temporary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattwthompson @codecov-commenter @j-wags