Adjusted image path in xcode.ko.md #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR has a merge conflict @alexhojinpark But if this doesn't work we might need to use absolute urls like: |
|
@alexhojinpark it's not shown on offline preview in repo because markdown files will be generate to static html file so leave image url as original will be better I guess. hope this helps. |
|
as I know as you update and pushed to your cloned repo(I mean github),
previous PR update automatically as well.
…On Wed, Dec 13, 2023 at 11:02 alexhojinpark ***@***.***> wrote:
@ofTheo <https://github.com/ofTheo> @icq4ever
<https://github.com/icq4ever> Thank you for the help. I've added absolute
URLs. Should I create a new pull request for these changes? I'm not very
familiar with the pull request process.
—
Reply to this email directly, view it on GitHub
<#816 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEBS3AAI7WJ2P2RFRCXYGDYJEEE5AVCNFSM6AAAAABAR7F7TCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTGE2TAMZWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you :) |
|
@alexhojinpark still there are conflicts. |
|
@icq4ever I'm assuming I have no permission to write or resolve conflicts, or I've done something wrong in Git commands while merging. I did a 'git pull' from master, switched to my branch, added, committed, and pushed to master. |
|
Not sure what the issue was, but I fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #815
I attempted to locate a path for images from ko/setup/xcode/xcode_setup_assets/install-dialog.webp, but couldn't find a solution(Image does not show up on my preview). I tested with VS Code default preview, and it seems adding ./ might work.
So, changing this:
to:
Hope it works, Thank you.