Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile and ofxaddons.com guide don't agree regarding file structure #896

Closed
bilderbuchi opened this issue Feb 5, 2012 · 7 comments
Closed

Comments

@bilderbuchi
Copy link
Member

This concerns libraries included in addons in source form. According to this issue reported by @danomatika, the makefile can only compile libraries' source code if they are in an addon's /src folder. This is in contradiction with @obviousjim's guide to addons' folder structure at http://ofxaddons.com/howto.

@danomatika
Copy link
Contributor

This is because the guide was written with OSX in mind. The Linux makefile compiles all the sources in the src directory and header and linking paths are set in config.make. For ofxPd, I simply moved the libpd source folder into src. It makes sense if you day precompiled and linked libs go in libs and raw lib sources go in src. I'd say the ofxaddons description should be changed.

@bilderbuchi
Copy link
Member Author

mirroring from the other issue, I 'd say change the makefile if this entails a feasible effort.
sure, this is not a dealbreaker, but at the least, the guide is wrong, at most the make file should be adapted to reflect the cleaner directory structure.
Don't you agree it would be cleaner to keep external libs' sources in their separate folder would be much cleaner than dumping them in the addon source folder?

[edited]

@danomatika
Copy link
Contributor

Also another note for those who haven't worked with OF on Linux. The makefile uses the name of its current folder for the name of the binary. So if the example is in an folder named "example" the app is named "example".

@danomatika
Copy link
Contributor

I'm copying this reply here for completeness:

Look at ofxPd. The makefile works recursively through the folders. Of course I didn't dump everything into a flat folder. Libpd has almost a hundred source files.

@bilderbuchi
Copy link
Member Author

I see your point. I think it's a matter of taste, then, where included libs' source files should reside, and I let others decide that. :-)

@danomatika
Copy link
Contributor

Sure. I originally wanted things all in libs, but it seemed easier to modify the structure rather then try to modify the entire Makefile system.

@bilderbuchi
Copy link
Member Author

I think we can close this, now that the new makefile system has landed in develop (which afaik follows the ofxAddonTemplate/ofxaddons.com).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants