🐛(build_images) add missing ask-vault-pass option #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
approved these changes
Dec 18, 2018
lunika
force-pushed
the
build_images-vault
branch
from
ac49140
to
de6ff66
Compare
jmaupetit
reviewed
Dec 18, 2018
ask-vault-pass option was missing in bin/build_images script
lunika
force-pushed
the
build_images-vault
branch
from
de6ff66
to
203680e
Compare
jmaupetit
added a commit
that referenced
this pull request
Dec 19, 2018
Added: - Edxapp Celery workers are now configurable (number of replicas and queues to consume) (#207) Fixed: - Pods deployment wait loop is now more robust by relying on the number of pod replicas instead of the number of deployments (#207) - Add missing ask-vault-pass option in bin/built_images script (#210) - Prevent htpasswd file overriding when running the create htpasswd playbook multiple times (#211)
jmaupetit
added a commit
that referenced
this pull request
Dec 19, 2018
Added: - Edxapp Celery workers are now configurable (number of replicas and queues to consume) (#207) Fixed: - Pods deployment wait loop is now more robust by relying on the number of pod replicas instead of the number of deployments (#207) - Add missing ask-vault-pass option in bin/built_images script (#210) - Prevent htpasswd file overriding when running the create htpasswd playbook multiple times (#211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
add missing ask-vault-pass option in
bin/build_imagesscriptFixes #209