⬆️(project) upgrade k3d release to v5.4.6 #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
added
dependencies
Now that CircleCI docker version is compatible with recent k3d releases, it's time to move on!
We need to explicitly set the `ingressClassName` of an ingress to make redirection work with recent ingress controllers.
jmaupetit
force-pushed
the
upgrade-k3d
branch
from
d783f9e
to
31ceb21
Compare
lunika
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Now that CircleCI docker version is compatible with recent k3d releases, it's time to move on!
Proposal
k3dtov5.4.6During this work I had to fix a recent regression with redirection ingresses not defining explicitly their
ingressClassName.Reference issue: k3d-io/k3d#807