Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛(acl) bugfix url matching for problem responses filenames #21

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

rmoch
Copy link
Contributor

@rmoch rmoch commented Oct 9, 2019

When instructors generate course problem responses reports, filename contains
course and problem url locators which use @ and +. We previously forgot
to consider this format.

fix #20

@rmoch rmoch force-pushed the bugfix-problem-responses-filename-matching branch from 5f7a776 to 0336df2 Compare October 9, 2019 13:04
CHANGELOG.md Outdated Show resolved Hide resolved
tests/views/test_acl.py Outdated Show resolved Hide resolved
tests/views/test_acl.py Outdated Show resolved Hide resolved
tests/views/test_acl.py Outdated Show resolved Hide resolved
@rmoch rmoch force-pushed the bugfix-problem-responses-filename-matching branch 2 times, most recently from b97c0b7 to 87f773d Compare October 9, 2019 13:42
CHANGELOG.md Outdated Show resolved Hide resolved
@rmoch rmoch force-pushed the bugfix-problem-responses-filename-matching branch 10 times, most recently from 739fd5c to 7b39e39 Compare October 9, 2019 17:05
@rmoch rmoch requested a review from jmaupetit October 9, 2019 17:12
@rmoch rmoch self-assigned this Oct 9, 2019
CHANGELOG.md Show resolved Hide resolved
fonzie/views/status.py Show resolved Hide resolved
Makefile Show resolved Hide resolved
@rmoch rmoch force-pushed the bugfix-problem-responses-filename-matching branch from 7b39e39 to 3992b0a Compare October 10, 2019 08:45
When instructors generate course problem responses reports, filename contains
course and problem url locators which use `@` and `+`. We previously forgot
to consider this format.
@rmoch rmoch force-pushed the bugfix-problem-responses-filename-matching branch 2 times, most recently from f2eeac1 to 2b41202 Compare October 10, 2019 09:28
move `tree` task as a requirement of `run` task instead of `bootstrap`, because
`bootstrap` task is not used by CI
@rmoch rmoch merged commit d18bbc6 into master Oct 10, 2019
@jmaupetit jmaupetit deleted the bugfix-problem-responses-filename-matching branch October 10, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acl application url pattern do not match all possible file names
3 participants