Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(models/api) add models and API endpoints for contract #358

Merged
merged 3 commits into from
Sep 26, 2023
Merged

✨(models/api) add models and API endpoints for contract #358

merged 3 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. ✅(factories) fix course run factory when forcing state 

    We have recently introduced a "Params" field that holds a "ref_date".
This date is computed when the Python code first loads. When the full
test suite is run, the gap between the ref_date and "now" computed in
tests can be significant and lead to random test failures because a
course run created with a state ONGOING_OPEN can in fact be closed...
    @sampaccoud
    sampaccoud committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f31f7f1 View commit details
    Browse the repository at this point in the history

  2. ✅(api) fix randomly failing test on order groups 

    This test required that the number of seats on the order group be
at least 3. It was randomly failing when the random number of seats
was chosen to be less than 3...
    @sampaccoud
    sampaccoud committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    157cae9 View commit details
    Browse the repository at this point in the history

  3. ✨(models/api) add contract models and API endpoints 

    We want to be able to sign learning conventions with students.
On the model of what was done for certificates, we add a
"ContractDefinition" model for universities to define the content
of the contract they want students to sign and a "Contract" model
to record actual contracts for each student on an order.
    @sampaccoud
    sampaccoud committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7d42bf7 View commit details
    Browse the repository at this point in the history