🚨(eslint) sort module names #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/eslint-order-modules
branch
from
fcb91e7
to
0e29238
Compare
We were sorting the import path but not the module names. We added a new rule to sort the module names as well. It is a automatic fixable rule.
kernicPanel
approved these changes
Jul 17, 2023
lunika
added a commit
that referenced
this pull request
Aug 29, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
Merged
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We were sorting the import path but not the module names.
We added a new rule to sort the module names as well.
It is a automatic fixable rule.
The magic is here: 0e29238#diff-de976b65c575e51acffc96c3e43599cc5e67a6c945213257e9c1a8b54a3ac093R67-R72