💄(frontend) replace to cunningham Datepicker #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will keep the dev from this conversation in this PR. |
AntoLC
force-pushed
the
feature/anthony/cunningham-datepicker
branch
from
69b51d8
to
405eddd
Compare
A PR has been submitted. If and when released, we will be able to merge this PR to master with the new version of |
AntoLC
force-pushed
the
feature/anthony/cunningham-datepicker
branch
from
405eddd
to
f7a521e
Compare
AntoLC
force-pushed
the
feature/anthony/cunningham-datepicker
branch
5 times, most recently
from
a3b5ca4
to
8be954b
Compare
lunika
reviewed
Aug 29, 2023
| * locale `en-CA` is used to convert the date in the format YYYY-MM-DD | ||
| */ | ||
| const local_new_retention_date = new_retention_date | ||
| ? new Date(new_retention_date).toLocaleDateString('en-CA') |
There was a problem hiding this comment.
Why using en-CA? We never use this locale in the application. Why not en-US ?
There was a problem hiding this comment.
The api want this pattern YYYY-MM-DD, so it is a trick to convert to the correct pattern.
en-US has this pattern DD/MM/YYYY, while en-CA has this one YYYY-MM-DD.
Anyway I had a problem during my tests with this way, so I changed it in the next commit:
8be954b#diff-cf30b5417dce67ce54bc983a20ab8a5e92150251f67c5f0209d08e351ac96ab8R68-R72
There was a problem hiding this comment.
In that case you should not rely on a locale but use the toFormat of luxon https://moment.github.io/luxon/#/formatting?id=toformat
There was a problem hiding this comment.
| fullWidth | ||
| label={intl.formatMessage(messages.startingAtDateTextLabel)} | ||
| locale={intl.locale} | ||
| maxValue={DateTime.local().plus({ years: 1 }).toISO() as string} |
There was a problem hiding this comment.
I don't remember why we choose to block to 1 year but IMO there is no reason to do that. You can remove it.
| import { useState } from 'react'; | ||
| import { | ||
| Classroom, | ||
| RetentionDate as CommunRetentionDate, |
There was a problem hiding this comment.
Suggested change
| RetentionDate as CommunRetentionDate, | |
| RetentionDate as CommonRetentionDate, |
There was a problem hiding this comment.
AntoLC
force-pushed
the
feature/anthony/cunningham-datepicker
branch
from
c731e89
to
5f743a5
Compare
Upgrade to cunningham@1.0.0, which includes an auto positionning of the datepicker depend of the place available.
AntoLC
force-pushed
the
feature/anthony/cunningham-datepicker
branch
from
5f743a5
to
4e1ef7a
Compare
lunika
approved these changes
Aug 29, 2023
Replace the Grommet Datepicker with the Cunningham Datepicker.
lib_video and lib_classroom have the same widget retention date, so we create a common widget in lib_components, it helps to develop and maintain the widget in one place.
AntoLC
force-pushed
the
feature/anthony/cunningham-datepicker
branch
from
f1f1e75
to
485cbd1
Compare
lunika
added a commit
that referenced
this pull request
Aug 29, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
Merged
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the Grommet Datepicker with the Cunningham Datepicker.
Proposal
Description...
Marsha.1.webm