✨(frontend) integrate cunningham #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/react18
branch
from
210c010
to
6497a5d
Compare
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
3 times, most recently
from
2fe1b58
to
730651f
Compare
AntoLC
force-pushed
the
feature/anthony/react18
branch
from
9a27ef0
to
6ccb9b1
Compare
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
2 times, most recently
from
2e36b29
to
04c3a8f
Compare
|
We just need this PR on the Cunningham side to be released and all good. |
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
6 times, most recently
from
7ff711d
to
0025936
Compare
polyhb
reviewed
Jul 18, 2023
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
83b5577
to
ea3f0d6
Compare
kernicPanel
reviewed
Jul 19, 2023
src/frontend/packages/lib_components/src/common/SchedulingFields/index.tsx
Outdated
Show resolved
Hide resolved
|
I changed the retention datepicker as well: fixup! 💄(frontend) replace to cunningham Datepicker |
kernicPanel
approved these changes
Jul 19, 2023
| @@ -0,0 +1,39 @@ | |||
| /*@import '@openfun/cunningham-react/fonts';*/ | |||
There was a problem hiding this comment.
Hi @AntoLC, I wonder why did you comment this? Should it be merged?
There was a problem hiding this comment.
Hi, the font integration didn't seem to work, we have Roboto on our side as well so I just commented the line to come back on it later on.
I removed it, I will open an issue about it when the PR will be merged.
fixup! ➕(frontend) add cunningham design system
polyhb
approved these changes
Jul 20, 2023
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
5868787
to
984a3bd
Compare
lunika
reviewed
Jul 25, 2023
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
984a3bd
to
9b9ade6
Compare
The component doesn't have a localhost_8060_development_.webm@lunika Could you scroll on the datepicker ? |
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
9b9ade6
to
d6f8e86
Compare
|
@AntoLC I can't scroll, the iframe height is not modified and I can't see the datepicker |
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
d6f8e86
to
db8887c
Compare
From our conversation, I removed the commit about the DatePicker, only stays the Cunningham integration in this PR. |
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
db8887c
to
5e3f680
Compare
lunika
approved these changes
Aug 1, 2023
Add cunningham design system to the apps. We generate the necessary files from lib-common to serve the design system to the apps.
AntoLC
force-pushed
the
feature/anthony/cunningham
branch
from
5e3f680
to
b57ff9e
Compare
This was referenced Aug 1, 2023
lunika
added a commit
that referenced
this pull request
Aug 29, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
Merged
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
lunika
added a commit
that referenced
this pull request
Aug 30, 2023
Added - Create a default playlist for new shibboleth user - Add Cunningham design system (#2297) - Lifecycle rule on source bucket to expire uploaded object after 21 days. - Add P2p feature on videojs player - Webtorrent tracker for P2P video feature - eslint sort the modules name (#2338) - Add retention date and s3 lifecycle rules to classroom / video - Add a command to delete expired classrooms / videos - Add retention duration on playlist form - Add retention date widget to video and classroom - Add a download-video widget directly in the video player - Configure sentry in the webtorrent application - Add custom frontend site management - Manage multiple ingresses - Manage shibboleth config per site config - Add a shared media widget directly in the video player - Add a transcript plugin to the video player - Add a link to LTI resources to retrieve them in the standalone website - Add Language Picker in the standalone website (#2366) - Add xapi statements cache to avoid duplicate statements - Add variable to override PVC in arnold deployment Changed - Upgrade frontend to React 18 (#2280) - Upgrade to django 4.2 - `DJANGO_STATICFILES_STORAGE` environment variable is replaced by `DJANGO_STORAGES_STATICFILES_BACKEND` - Use alpine for installing mediainfo in lambda docker images - Add compatibility with docker compose 2 - tslint is replaced by eslint in lti app (#2321) - refactor videojs id3 tags handling as videojs plugin - refactor videojs xapi handling as videojs plugin - upgrade react-query to @tanstack/react-query (v4) (#2340) - Replace component SortableTable by Cunningham DataGrid (#2311) - Replace grommet DatePicker by Cunningham DatePicker (#2359) Fixed - Video player reset when attributes update (#2300) - Fix panel closing and resizing on live video player chat (#2310) - Fix download video button when video is not downloadable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
cunninghamdesign system to the apps, load it fromlib-common.Integrate the component
DatePickercomponent to replace the grommet one.Proposal
Marsha.1.webm