Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐(lib_components) add the language in the request header #2394

Merged
merged 1 commit into from
Sep 5, 2023
Merged

🌐(lib_components) add the language in the request header #2394

merged 1 commit into from
Sep 5, 2023

Conversation

AntoLC
Copy link
Contributor

@AntoLC AntoLC commented Sep 1, 2023 •
edited
Loading

Purpose

During an http request, the language sent to the backend was the browser one, we now send the language setted in the app to get some possible backend messages internationalized.

Proposal

Description...

  • Add Accept-Language to the header from the fetchWrapper
  • Tests
Marsha.7.webm

Review

The main changes are here and here.

@AntoLC AntoLC self-assigned this Sep 1, 2023
@AntoLC AntoLC force-pushed the feature/anthony/fetchWrapperAcceptLanguage branch 7 times, most recently from 8ffa619 to 57bf98c Compare September 4, 2023 12:37
@AntoLC AntoLC marked this pull request as ready for review September 4, 2023 12:53
lunika
lunika approved these changes Sep 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@AntoLC
🌐(lib_components) add the language in the request header
88b723d 
The language sent to the backend was the browser one, we now send the
the language setted in the app to get the backend messages
internationalized.
@AntoLC AntoLC force-pushed the feature/anthony/fetchWrapperAcceptLanguage branch from 57bf98c to 88b723d Compare September 5, 2023 08:23
@AntoLC AntoLC enabled auto-merge (rebase) September 5, 2023 08:24
@AntoLC AntoLC merged commit 06de1d7 into master Sep 5, 2023
@AntoLC AntoLC deleted the feature/anthony/fetchWrapperAcceptLanguage branch September 5, 2023 08:39
lunika added a commit that referenced this pull request Sep 8, 2023
@lunika
🔖(minor) bump release to 4.4.0
6b85260 
Added

- Add playlist is_claimable attribute
- Add the Accept-Language header to most of the http request (#2394)

Changed

- Replace grommet TextInput by Cunningham Input (#2374)
- Save classroom recording urls in a cache and remove access from db column
lunika added a commit that referenced this pull request Sep 8, 2023
@lunika
🔖(minor) bump release to 4.4.0
bd2875a 
Added

- Add playlist is_claimable attribute
- Add the Accept-Language header to most of the http request (#2394)

Changed

- Replace grommet TextInput by Cunningham Input (#2374)
- Save classroom recording urls in a cache and remove access from db column
@lunika lunika mentioned this pull request Sep 8, 2023
Merged
lunika added a commit that referenced this pull request Sep 8, 2023
@lunika
🔖(minor) bump release to 4.4.0
302cb15 
Added

- Add playlist is_claimable attribute
- Add the Accept-Language header to most of the http request (#2394)

Changed

- Replace grommet TextInput by Cunningham Input (#2374)
- Save classroom recording urls in a cache and remove access from db column
@AntoLC AntoLC mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunika lunika lunika approved these changes

@kernicPanel kernicPanel kernicPanel approved these changes

Assignees

@AntoLC AntoLC

Labels
Frontend improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoLC @kernicPanel @lunika