♻️(frontend) replace Text grommet #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/replace-text-grommet
branch
12 times, most recently
from
98cf7eb
to
f951fae
Compare
AntoLC
force-pushed
the
feature/anthony/replace-text-grommet
branch
3 times, most recently
from
1193a74
to
1065af9
Compare
AntoLC
changed the title
kernicPanel
approved these changes
Oct 2, 2023
lunika
reviewed
Oct 3, 2023
Comment on lines
8
to
40
| type Values<T> = T[keyof T]; | ||
| export type ObtainHTMLProps<T extends Values<ReactHTML>> = | ||
| T extends DetailedHTMLFactory<infer Props, HTMLElement> ? Props : never; | ||
|
|
||
| export interface TypoPropsOnly<T> { | ||
| textAlign?: CSSProperties['textAlign']; | ||
| color?: CSSProperties['color']; | ||
| fontSize?: CSSProperties['fontSize']; | ||
| truncate?: boolean | number; | ||
| type?: keyof T; | ||
| } | ||
|
|
||
| export type TypoProps<T extends keyof ReactHTML> = TypoPropsOnly<ReactHTML> & | ||
| ObtainHTMLProps<ReactHTML[T]>; |
There was a problem hiding this comment.
Can you add comment on this type please. They are not trivial.
AntoLC
force-pushed
the
feature/anthony/replace-text-grommet
branch
5 times, most recently
from
c0d1563
to
5fe6b0a
Compare
AntoLC
force-pushed
the
feature/anthony/replace-text-grommet
branch
from
5fe6b0a
to
f14cfc0
Compare
lunika
approved these changes
Oct 4, 2023
The way to override the cunningham tokens was not the recommended way, we changed it to a more recommended way, it will help to get inner functionnalities bring by the cunningham design system like css class generation.
Typo is a generic component that can be used to render any HTML tag, it includes a set of predefined methods and styles adapted with the Cunningham design system. It will make it easier to create new specific html components and to maintain the consistency of the design system. We refacto Headings component to use Typo component.
Text component is based from the Typo component, it uses the Cunningham classname system. This component replace the Grommet Text component.
We replace the Grommet Text component with our own Text component based on the Cunnigham design system.
AntoLC
force-pushed
the
feature/anthony/replace-text-grommet
branch
from
f14cfc0
to
ade02f7
Compare
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the grommet
Textcomponent by our custom componentTextcomponent base on the Cunningham design system.Proposal
Typocomponent - A generic component grouping common element featureHeadingcomponent to useTypocomponentTextcomponent based onTypocomponentTextwith customText