Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄(website) remove cross on login image #2451

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

AntoLC
Copy link
Contributor

@AntoLC AntoLC commented Oct 5, 2023

Purpose

A cross was drawn on the login image, it didn't have any purpose.

Before

image

After

image

@AntoLC AntoLC self-assigned this Oct 5, 2023
@AntoLC AntoLC added easy pick feature request Site Linked to the marsha site labels Oct 5, 2023
@AntoLC AntoLC force-pushed the fix/anthony/remove-cross-login-img branch from aa0ef46 to 043138e Compare October 5, 2023 08:06
@AntoLC AntoLC marked this pull request as ready for review October 5, 2023 08:06
@AntoLC AntoLC requested a review from lunika October 5, 2023 08:06
A cross was drawn on the login image, it didn't have any purpose,
this commit removes it.
@AntoLC AntoLC force-pushed the fix/anthony/remove-cross-login-img branch from 043138e to c459932 Compare October 5, 2023 15:40
@AntoLC AntoLC enabled auto-merge (rebase) October 5, 2023 15:41
@AntoLC AntoLC merged commit 4915590 into master Oct 5, 2023
33 of 34 checks passed
@AntoLC AntoLC deleted the fix/anthony/remove-cross-login-img branch October 5, 2023 15:58
lunika added a commit that referenced this pull request Oct 19, 2023
Added

- Generic video LTI url
- Display complete error message in frontend
- Generic classroom LTI url
- Generic LTI cartridge (xml configuration)
- Display LTI warning message for generic urls regarding course copy
- configure homepage banner using SiteConfig model
- setting BBB_INVITE_TOKEN_BANNED_LIST
- Add transcode_pipeline property to video model

Changed

- Replace ngrok with localtunnel to serve marsha on a public domain with
  stable urls and allow to run multiple tunnels at the same time
- Replace all the loaders by Cunningham Loader (#2436)
- Replace grommet Text (#2427)
- Replace grommet Paragraph (#2435)
- Remove cross on login image (#2451)
- Replace grommet Checkbox and Pagination (#2437)

Fixed

- Markdown save sent previously saved content
- Force to end BBB meeting when creation fail
lunika added a commit that referenced this pull request Oct 19, 2023
Added

- Generic video LTI url
- Display complete error message in frontend
- Generic classroom LTI url
- Generic LTI cartridge (xml configuration)
- Display LTI warning message for generic urls regarding course copy
- configure homepage banner using SiteConfig model
- setting BBB_INVITE_TOKEN_BANNED_LIST
- Add transcode_pipeline property to video model

Changed

- Replace ngrok with localtunnel to serve marsha on a public domain with
  stable urls and allow to run multiple tunnels at the same time
- Replace all the loaders by Cunningham Loader (#2436)
- Replace grommet Text (#2427)
- Replace grommet Paragraph (#2435)
- Remove cross on login image (#2451)
- Replace grommet Checkbox and Pagination (#2437)

Fixed

- Markdown save sent previously saved content
- Force to end BBB meeting when creation fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy pick feature request Site Linked to the marsha site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants