♻️(frontend) replace the loaders with Cunningham Loader #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/replace-grommet-spinner
branch
5 times, most recently
from
ce69342
to
f068a8e
Compare
kernicPanel
approved these changes
Oct 2, 2023
| @@ -83,7 +83,7 @@ describe('<Lives/>', () => { | |||
| client: queryClient, | |||
| }, | |||
| }); | |||
| expect(screen.getByRole('alert', { name: /spinner/i })).toBeInTheDocument(); | |||
| expect(screen.getByLabelText('loader')).toBeInTheDocument(); | |||
There was a problem hiding this comment.
FMI, where does loader label comes from ?
There was a problem hiding this comment.
AntoLC
force-pushed
the
feature/anthony/replace-grommet-spinner
branch
2 times, most recently
from
11831cb
to
a4ad251
Compare
lunika
approved these changes
Oct 3, 2023
SidebarUploadsIndicator is not used anywhere in the app, we delete it.
Create the component BoxLoader, it will replace CenterLoader, Spinner, ContentSpinner, and Loader. It uses the Cunningham Loader.
Replace all the loaders with Cunningham Loader
AntoLC
force-pushed
the
feature/anthony/replace-grommet-spinner
branch
from
a4ad251
to
e61b477
Compare
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace all the loaders with Cunningham Loader
Proposal