♻️ Replace form components #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/anthony/replace-form-components
branch
6 times, most recently
from
5ef75d6
to
e0b882d
Compare
AntoLC
force-pushed
the
refacto/anthony/replace-form-components
branch
from
e0b882d
to
e2c2dd0
Compare
kernicPanel
reviewed
Oct 5, 2023
src/frontend/apps/lti_site/apps/deposit/components/Dashboard/DashboardInstructor/index.tsx
Show resolved
Hide resolved
kernicPanel
reviewed
Oct 6, 2023
Indeed. |
AntoLC
force-pushed
the
refacto/anthony/replace-form-components
branch
from
4409657
to
d031660
Compare
kernicPanel
approved these changes
Oct 6, 2023
kernicPanel
added a commit
that referenced
this pull request
Oct 9, 2023
Cunningham uprade to 1.3 (which needs a fix in our codebase) is managed in another PR (#2437).
lunika
reviewed
Oct 9, 2023
Comment on lines
+402
to
+409
| <div class="input-group"> | ||
| <label>lis_person_name_full</label> | ||
| <input type="text" name="lis_person_name_full" value="John Doe"/> | ||
| </div> |
There was a problem hiding this comment.
To be iso it should also be added to the form managing the iframe
AntoLC
force-pushed
the
refacto/anthony/replace-form-components
branch
from
d031660
to
1b60d44
Compare
lunika
approved these changes
Oct 9, 2023
kernicPanel
added a commit
that referenced
this pull request
Oct 10, 2023
Cunningham uprade to 1.3 (which needs a fix in our codebase) is managed in another PR (#2437).
kernicPanel
added a commit
that referenced
this pull request
Oct 10, 2023
Cunningham uprade to 1.3 (which needs a fix in our codebase) is managed in another PR (#2437).
Upgrade to cunningham@1.3.1, this version fix somes issues and add new usefull css properties.
Component to display an error message in a box with an appropriate icon and a message.
The upgrade to Cunningham highlighted a few issues with the LicenseSelect component, the refacto displays the state of the component in a more explicit way.
In some cases we want to be able to change the fullname of the user, to do so, we change the input from hidden to text.
In order to do the transition to the cunningham design system, we replace the grommet CheckBox component with the cunningham Checkbox components.
In order to do the transition to the cunningham design system, we replace the grommet Pagination component with the cunningham Pagination components.
AntoLC
force-pushed
the
refacto/anthony/replace-form-components
branch
from
1b60d44
to
ec5238c
Compare
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
lunika
added a commit
that referenced
this pull request
Oct 19, 2023
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace Grommet form components with Cunningham form components.
Proposal
Before merging
Checkbox change
Before
After
Pagination change
Before
After