Add edxapp-nginx extras #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question is: do we really need the "non-slim" images... is slim not the one and only edxapp-nginx image!? |
sampaccoud
reviewed
Jan 15, 2020
Of course we won't build or use non-slim image! This table's purpose is to quantify the image size variation with and without |
sampaccoud
reviewed
Jan 15, 2020
jmaupetit
force-pushed
the
add-statics-in-nginx
branch
from
dcd779a
to
8fb728e
Compare
lunika
reviewed
Jan 17, 2020
|
@lunika I've added a fixup commit for your comment. Feel free to review it once again 🙏 |
jmaupetit
force-pushed
the
add-statics-in-nginx
branch
3 times, most recently
from
f1440ac
to
d571494
Compare
lunika
reviewed
Jan 20, 2020
jmaupetit
force-pushed
the
add-statics-in-nginx
branch
2 times, most recently
from
b91e1e3
to
ff435b1
Compare
lunika
approved these changes
Jan 20, 2020
jmaupetit
force-pushed
the
add-statics-in-nginx
branch
from
ff435b1
to
e3d39ee
Compare
We need a way to bundle an openedx release assets with the nginx image that will serve them to avoid side-effects in our deployment procedure (see the Arnold project). Current work copy files collected in the edxapp release and replace duplicates by symlinks to save disk space and network bandwidth (up to 65%): dogwood.3-1.2.1 529MB dogwood.3-1.2.1-slim 198MB eucalyptus.3-1.1.1 573MB eucalyptus.3-1.1.1-slim 222MB hawthorn.1-3.0.0 959MB hawthorn.1-3.0.0-slim 320MB hawthorn.1-oee-3.0.0 960MB hawthorn.1-oee-3.0.0-slim 320MB *-slim images have been generated with the aforementioned optimization.
We now use the latest docker-compose release. Release notes: https://github.com/docker/compose/releases/tag/1.25.1
We recently cleaned and renamed branches from our edx/edx-platform branch. The `fun/whitebrand` has been renamed `eucalyptus.3-wb` for cross-project consistency.
jmaupetit
force-pushed
the
add-statics-in-nginx
branch
from
e3d39ee
to
7de4bed
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need a way to bundle an openedx release assets with the
nginximage that will serve them to avoid side-effects in our deployment procedure (see the Arnold project).Proposal
Current work copy files collected in the edxapp release and replace duplicates by symlinks to save disk space and network bandwidth (up to 65%):
*-slim images have been generated with the aforementioned optimization.
During this work, I've also:
docker-composerelease to1.25.1eucalyptus/3/wbgit branch reference