Unit registries #6

rgm · 2020-04-21T00:07:59Z

Every one of our projects seems to require a slightly different set of units. A central concept in Pint is user-definable registries. Let's bring that in, and make the make-quantity fn take a unit registry as its first argument so that the validation, etc. can vary per project.

Proposed API:

(require '[opengb.dram.core :as dram])

(def unit-reg (-> (dram/make-unit-registry)
                  (dram/define-unit "air-change = [airflow] =  ac")
                  (dram/define-unit "[airtightness] = [airflow] / [time]")))

(def Q_ (partial dram/make-quantity unit-registry))

We'll need this to cope with pint's unit definition syntax.

We'll want to be line-for-line compatible to maximize our ability to stand on Pint's shoulders, here.

Make a naive implementation that is just enough to test the construction of record-type quantities with a partial in a separate project. Currently this has zero protection against unregistered units, or implementation of arithmetic or conversion. Going down a record-based implementation to experiment with getting the faster dispatch (that ought to be possible) over the older vector-based tuple implementation.

Seems we need to implement IEquiv as well for node + browser repl

For kilo, milli, etc. Following pint's definition convention.

Just rely on the clojure one.

Without this guard, clojurescript equality checks can blow up.

rgm added 14 commits April 20, 2020 23:42

Reorganize deps.edn

8e8f2b6

Adds a test runner watch cmd

68e0d1e

Adds instaparse

05dc0ad

We'll need this to cope with pint's unit definition syntax.

Pulls in pint unit definitions

5902930

We'll want to be line-for-line compatible to maximize our ability to stand on Pint's shoulders, here.

Runs cljfmt

7aaf226

Implements deftype equality, toString

c19025f

Make Quantity a capitalized type, per convention

16b868e

Fixes object equality in cljs

e56c64f

Seems we need to implement IEquiv as well for node + browser repl

Make it clearer we're using a dummy registry in tests just now

d6f42c8

Stub in define-prefix

6794877

For kilo, milli, etc. Following pint's definition convention.

Removes spec dependency

df9f46e

Just rely on the clojure one.

Fix equality to first make sure we can call IQuantity methods

9ee7e00

Add a guard on IEquiv

df055ae

Without this guard, clojurescript equality checks can blow up.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit registries #6

Unit registries #6

rgm commented Apr 21, 2020 •

edited

Loading

Unit registries #6

Are you sure you want to change the base?

Unit registries #6

Conversation

rgm commented Apr 21, 2020 • edited Loading

rgm commented Apr 21, 2020 •

edited

Loading