Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyG trimming? #25

Closed
mht85 opened this issue Jan 30, 2018 · 5 comments
Closed

PolyG trimming? #25

mht85 opened this issue Jan 30, 2018 · 5 comments

Comments

@mht85
Copy link

mht85 commented Jan 30, 2018

Hello,

Thanks for the program. I'm working with NovaSeq data currently and would like to try out the polyG trimming. After trimming, it looks like fastp still retains reads with 8 or less Gs at the ends of reads. Is that a default set by fastp and what is the reason for doing so? Any way I can change the number of G's fastp lets through its filter?

Cheers,
Mun

@sfchen
Copy link
Member

sfchen commented Jan 30, 2018

Currently fastp doesn't trim polyG with G number less than 10. If you prefer a parameter to adjust this setting, I will implement it in the coming version.

@mht85
Copy link
Author

mht85 commented Jan 30, 2018

It would be nice to have the option to adjust that setting. Would also be great to have the count included in the report? Just a suggestion. Thanks for the software by the way. May I know when the next version will be released?

@sfchen
Copy link
Member

sfchen commented Jan 30, 2018

Next revision will come in two weeks.

sfchen added a commit that referenced this issue Feb 4, 2018
@sfchen
Copy link
Member

sfchen commented Feb 4, 2018

With the latest version in the master branch, you can use --poly_g_min_len to change the minimum length requirement for polyG detection. By default it's 10.

@sfchen
Copy link
Member

sfchen commented Feb 21, 2018

Any update? Have you tried the new fastp, which can be compiled from the latest code, or downloaded from http://opengene.org/fastp/fastp ?

@sfchen sfchen closed this as completed Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants