-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings to functions #20
Comments
@AdiChat I would like to work on this issue. |
@yashasingh Go for it. 👍 |
If the function does not explicitly return do we still need to provide a description beyond returns None? |
I think that for the functions that don't return anything, just include a general description of the function and it's inputs. I would exclude the Returns portion of the docstring in these functions. @AdiChat what do you think? Also, don't use Returns None. None is an object in python. Please chime in if you think it should be handled differently |
I agree 👍 |
Need to reopen issue... I found several minor issues with the docstrings and will submit a PR |
Sure 👍 |
@bhaveshAn has done a wonderful job but the docstrings have minor flaws and were changed. 1. Some of the parameter types were missing thus added 2. Unncessary notes about obvious aspects of function were include thus deleted 3. Non-consistent styling of docstrings, thus thry were reformatted for style and consistency 4. Docstring text exceeded PEP8 line length of 79 characters thus reformatted to abide by std Issue OpenGenus#20 and PR OpenGenus#30
Overall:
A docstring should be included at the top of code to summarize project @AdiChat This might be good for you to do
Specifically (see example below): This could be done by other contributers
The text was updated successfully, but these errors were encountered: