Fix rtree creation SQL statement #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original statement fails in the case where some of the existing geometries are empty. The error message is: rtree constraint failed: rtree_Building_geom.(minx<=maxx) This change modifies the statement so that it only attempts to populate the rtree with non-empty (or NULL) geometries. This is consistent with the rtree triggers.
bosborn
reviewed
May 19, 2020
| @@ -88,7 +88,7 @@ Each newly created spatial index SHALL be populated using the following SQL stat | |||
| [source,sql] | |||
| ---- | |||
| INSERT OR REPLACE INTO rtree_<t>_<c> | |||
| SELECT <i>, st_minx(<c>), st_maxx(<c>), st_miny(<c>), st_maxy(<c>) FROM <t>; | |||
| SELECT <i>, st_minx(<c>), st_maxx(<c>), st_miny(<c>), st_maxy(<c>) FROM <t> WHERE <c> NOT NULL AND NOT ST_Empty(<c>); | |||
There was a problem hiding this comment.
@jyutzler @peterstace ST_Empty should be ST_IsEmpty to match the RTree Extension SQL Function specification.
The case of the existing functions should probably be corrected as well: ST_MinX, ST_MaxX, ST_MinY, ST_MaxY
This was referenced Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original statement fails in the case where some of the existing
geometries are empty. The error message is:
This change modifies the statement so that it only attempts to populate
the rtree with non-empty (or NULL) geometries. This is consistent with
the rtree triggers.