Test some QML components
#5375
Merged
Test some QML components
#5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 1f9226e: arm64-android |
Still need to enhance the coverage of this basic test.
nirvn
reviewed
Jun 25, 2024
There was a problem hiding this comment.
@mohsenD98 , just a few comments, thanks, this already adds good additional CI checks. Lovely.
nirvn
reviewed
Jun 27, 2024
test/test_qml.cpp
Outdated
| #include <qgsvectorlayereditbuffer.h> | ||
| #include <qgswkbtypes.h> | ||
|
|
||
| #include <valuemapmodel.h> |
There was a problem hiding this comment.
one last thing @mohsenD98, this is one of our own header, it should go up alongside the #include "positioning.h" and not use <>.
nirvn
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a set of tests for the QML components provided by the EditorWidgets module. The tests cover various aspects of each component, including their initial state, configuration options, and functionality. The tests are organized into separate functions, each of which focuses on a specific component.
The components tested in this pull request are:
TextEdit: Tests its ability to set and get values, as well as its configuration options for multiline and HTML text.
Range: Verifies its initial value, default values, and configuration options for style, precision, min, max, step, and suffix.
DateTime: Tests its display formats, calendar popup, and field format options.
CheckBox: Verifies its initial state, checked and unchecked states, and configuration options for display method and type.
ValueMap: Tests its properties, including toggle buttons and combobox models, as well as its value and current key value.
UuidGenerator: Verifies its initial state and value, as well as its isLoaded and isAdding properties.