Fix wrong test in test_organization #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faebebin
added
patch
faebebin
commented
Jun 27, 2023
| @@ -259,7 +259,7 @@ def _active_users_count(base_date=None): | |||
| # User 3 creates a job | |||
| Job.objects.create( | |||
| project=project1, | |||
| created_by=self.user3, | |||
| created_by=self.user4, | |||
| ) | |||
There was a problem hiding this comment.
Anyway I would suggest reqriting all test comments so that are easier to read. The comments mention User 1 and the refer to self.user2 and User 2 referring to self.user3 ... . This is super hard to read and probably led to this bug?
I would suggest using user2 directly in the comment or writing:
# 1. user2 creates ...
# 2. user3 does x
...
what you think?
There was a problem hiding this comment.
Absolutely in favor of everything that easily adds a readability improvement.
suricactus
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty sure this is meant?