Filters visible layers for packaging offline project #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricactus
reviewed
Jul 15, 2024
suricactus
reviewed
Jul 15, 2024
suricactus
reviewed
Jul 15, 2024
|
@SeqLaz thanks for your amazing contribution! I left a few comments, mostly nit-picks. One major questions is if we can move the filter to the top of the table, between "Layers" label and the table itself. I think it makes more sense as in QGIS most of the UI is from top to bottom. Also the eye icon on the top-right can be moved on the same row as the other three filters. |
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
|
Hey @suricactus I did the suggested changes! Test.layers.filters.mp4 |
gacarrillor
reviewed
Aug 7, 2024
|
New Design |
suricactus
approved these changes
Aug 27, 2024
suricactus
deleted the
QF-4546-filter_visible_layers_for_packaging_offline_project
branch
|
Thanks a lot of the amazing contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates enhancements to the functionality mentioned in issue #438
test-filters-layers-inproperties.mp4