Skip to content

Commit

Permalink
Merge branch 'develop' into ref/ts-analytics-routes
Browse files Browse the repository at this point in the history
# Conflicts:
#	src/config/feature-manager/util/FeatureManager.class.ts
  • Loading branch information
karrui committed Oct 5, 2020
2 parents 426278c + df08618 commit 1aa84e2
Show file tree
Hide file tree
Showing 25 changed files with 655 additions and 461 deletions.
164 changes: 101 additions & 63 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"@opengovsg/myinfo-gov-client": "^1.0.4",
"@opengovsg/ng-file-upload": "^12.2.14",
"@opengovsg/spcp-auth-client": "^1.3.5",
"@sentry/browser": "^5.22.3",
"@sentry/browser": "^5.24.2",
"@sentry/integrations": "^5.24.2",
"@stablelib/base64": "^1.0.0",
"JSONStream": "^1.3.5",
Expand Down Expand Up @@ -133,14 +133,14 @@
"moment-timezone": "0.5.31",
"mongodb-uri": "^0.9.7",
"mongoose": "^5.10.0",
"multiparty": ">=4.1.3",
"multiparty": ">=4.2.2",
"neverthrow": "^2.7.1",
"ng-infinite-scroll": "^1.3.0",
"ng-table": "^3.0.1",
"ngclipboard": "^2.0.0",
"nocache": "^2.1.0",
"node-cache": "^5.1.2",
"nodemailer": "^6.4.11",
"nodemailer": "^6.4.12",
"nodemailer-direct-transport": "~3.3.2",
"opossum": "^5.0.1",
"promise-retry": "^2.0.1",
Expand Down Expand Up @@ -205,7 +205,7 @@
"css-loader": "^2.1.1",
"csv-parse": "^4.12.0",
"env-cmd": "^10.1.0",
"eslint": "^7.9.0",
"eslint": "^7.10.0",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-angular": "^4.0.1",
"eslint-plugin-html": "^6.0.2",
Expand Down
48 changes: 0 additions & 48 deletions src/app/factories/sms.factory.js

This file was deleted.

4 changes: 2 additions & 2 deletions src/app/models/form.server.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export interface IFormModel extends Model<IFormSchema> {
deactivateById(formId: string): Promise<IFormSchema | null>
}

type IEncryptedFormModel = Model<IEncryptedFormSchema>
type IEncryptedFormModel = Model<IEncryptedFormSchema> & IFormModel

const EncryptedFormSchema = new Schema<IEncryptedFormSchema>({
publicKey: {
Expand All @@ -101,7 +101,7 @@ const EncryptedFormSchema = new Schema<IEncryptedFormSchema>({
},
})

type IEmailFormModel = Model<IEmailFormSchema>
type IEmailFormModel = Model<IEmailFormSchema> & IFormModel

const EmailFormSchema = new Schema<IEmailFormSchema>({
emails: {
Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/user/user.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { StatusCodes } from 'http-status-codes'

import { createLoggerWithLabel } from '../../../config/logger'
import { IPopulatedUser } from '../../../types'
import SmsFactory from '../../factories/sms.factory'
import { SmsFactory } from '../../services/sms/sms.factory'
import { ApplicationError } from '../core/core.errors'

import {
Expand Down
Loading

0 comments on commit 1aa84e2

Please sign in to comment.