Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release 4.56.0 - table dropdown fix, deprecate MyInfo fields #1079

Merged
merged 6 commits into from
Feb 4, 2021

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Feb 4, 2021

New

  • feat: filter deprecated fields from admin panel #1071
  • feat: add MyInfo db migration scripts #1072

Bug fixes

  • fix: apply dropdown padding on whole table #1078

Improvements

@mantariksh
Copy link
Contributor Author

mantariksh commented Feb 4, 2021

Tests

IE11 intranet general run-through

  • Create email mode form with all fields. Activate and submit form. Check that you can receive responses in your intranet inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments for individual fields can be downloaded from Data tab in storage mode.
  • Attachment ZIP for submission can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

@mantariksh
Copy link
Contributor Author

mantariksh commented Feb 4, 2021

Tests

IE11 intranet

  • Home number, mailing address, billing address, education level, school name and graduation year are missing from MyInfo options in Build tab
    - [ ] Existing forms with these fields can still be submitted (none of the MyInfo test profiles are working)
  • Existing forms with these fields can still be edited. The deprecated fields can be edited, reordered and deleted.

@mantariksh
Copy link
Contributor Author

mantariksh commented Feb 4, 2021

Tests

IE11 intranet

  • Create a table field with multiple text and dropdown columns, where additional rows can be added. In the mobile view, check that opening a dropdown in either of the last 2 rows results in additional padding appearing at the bottom of the table, such that the dropdown options are visible.
  • Add rows to the table field and check that the padding still only applies to the newly created last 2 rows.
  • Delete the rows which were added and check that the behaviour is consistent.
  • Repeat the above 3 checks for the desktop view.

arshadali172
arshadali172 previously approved these changes Feb 4, 2021
@mantariksh
Copy link
Contributor Author

mantariksh commented Feb 4, 2021

Tests

  • .oa file can be attached and submitted in email mode
  • .oa file can be attached and submitted in storage mode
  • .oa file can be downloaded from Data tab individual response
  • .oa file can be downloaded in ZIP for individual submission
  • .oa file can be downloaded in bulk attachments

@mantariksh mantariksh merged commit bfdd0fb into release Feb 4, 2021
@karrui karrui deleted the release-4.56.0 branch April 21, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants