Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump connect-mongo from 3.2.0 to 4.2.0 #1240

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 24, 2021

Bumps connect-mongo from 3.2.0 to 4.2.0.

Changelog

Sourced from connect-mongo's changelog.

[4.2.0] - 2021-02-24

Added

  • Added mongoose example
  • Revert createAutoRemoveIdx and add back autoRemove and autoRemoveInterval

Fixed

  • Use matchedCount instead of modifiedCount to avoid throwing exceptions when nothing to modify (#390)
  • Fixed Warning: Accessing non-existent property 'MongoError' of module exports inside circular dependency by downgrade to mongodb@3.6.3
  • Revert update session when touch (#351)
  • Fix cannot read property lastModified of null
  • Fix TS typing error

[4.1.0] - 2021-02-22

BREAKING CHANGES

  • Support Node.Js 10.x, 12.x and 14.x and drop older support.
  • Review method to connect to MongoDB and keep only mongoUrl and clientPromise options.
  • Remove the "Remove expired sessions compatibility mode". Now library user can choose to create auto remove index on startup or not.
  • Remove fallbackMemory options.
  • Rewrite the library and test case using typescript.

Checkout the complete migration guide for more details.

Commits
  • 3ca6ac7 chore: bump version to 4.2.0
  • baaf3fd chore: update example
  • 8c1d180 feat: revert createAutoRemoveIdx and add back autoRemove and autoRemoveInterval
  • 001a86b fix: fix TS typing error (#391)
  • 6bd6002 docs: update changelog
  • b8b3387 chore: correct way to extend SessionData
  • 46a40db fix: cannot read property lastModified of null
  • 468f516 test: add super test as integration test framework
  • 7f6515c docs: add TOC
  • cf20a6e chore: bump version for next bugfix relase testing
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 24, 2021
@karrui
Copy link
Contributor

karrui commented Mar 1, 2021

Fixed the errors due to breaking changes in connect-mongo, following new mongoose example docs.

@karrui
Copy link
Contributor

karrui commented Mar 2, 2021

seems to be failing to process some session-related functions....

 TypeError: Cannot read property 'db' of undefined
        at /Users/karrui/Projects/FormSG/node_modules/connect-mongo/src/lib/MongoStore.ts:199:26
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

Can't find anything on the connect-mongo issue tracker

@karrui
Copy link
Contributor

karrui commented Mar 2, 2021

using session memorystore in test environment fixes the above issue

@karrui
Copy link
Contributor

karrui commented Mar 2, 2021

Don't know if we really want to upgrade this dependency though, seems like no real benefits and the current implementation is working well.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 2, 2021

A newer version of connect-mongo exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@mantariksh mantariksh merged commit 579dcfa into develop Mar 3, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/connect-mongo-4.2.0 branch March 3, 2021 05:03
@tshuli tshuli mentioned this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants